Package / Actions Cleanup - Continuation of #435#436
Package / Actions Cleanup - Continuation of #435#436simmsa wants to merge 75 commits intoMHKiT-Software:developfrom
Conversation
There is a bug where something in requiring pyarrow that is likely related to pandas 3.0. Adding pyarrow as a dependency is a reasonable fix, but managing the pyarrow version should be handled by pandas and not mhkit. This pins pandas below 3.0 to see if pyarrow dependencies are caused by including >= 3.0 somewhere.
``` prepare-nonhindcast-cache The 'defaults' channel might have been added implicitly. If this is intentional, add 'defaults' to the 'channels' list. Otherwise, consider setting 'conda-remove-defaults' to 'true'. ```
.github/workflows/main.yml
Outdated
| shell: bash -l {0} | ||
| run: | | ||
| conda env create -f environment-dev.yml | ||
| conda activate mhkit-dev-env |
There was a problem hiding this comment.
So, this "env create" line (319) is actually redundant after the "Setup Miniconda" routine in line 304. You just need line 320 here is activate the environment.
There was a problem hiding this comment.
@jmcvey3 good call on venv over conda for pip install testing. This is definitely a gap in the documentation and tests.
I will work to refactor accordingly including updating the README documentation to recommend venv for pip installs and updating the tests.
There was a problem hiding this comment.
So, this "env create" line (319) is actually redundant after the "Setup Miniconda" routine in line 304. You just need line 320 here is activate the environment.
Good find here, also. Will fix...
Previously we had `python>=3.10,<3.13` but this was likely legacy from the conda-forge version of the conda config. This removes the ambiguous python version, which relied on the solver, to a deterministic version with the intent of providing reproducible builds for conda users.
| **Pip development** (no conda): | ||
|
|
||
| ```bash | ||
| pip install -e ".[all,dev]" |
There was a problem hiding this comment.
Just adding a note to create and activate a venv environment here
There was a problem hiding this comment.
Good call, will update accordingly. LMK if other areas don't make sense here either, or could be clarified.
These changes were a reaction to failing tests, but it is likely that the failing tests were not caused by this code specifically, but pandas 3.0 updates. This reverts these changes back to the develop branch as they are likely unnecessary for the tests to pass when pandas is pinned below 3.0
``` FAILED .github/workflows/test_read_adp.py::io_adp_testcase::test_io_nortek - FileNotFoundError: [Errno 2] No such file or directory: '/home/runner/work/MHKiT-Python/MHKiT-Python/examples/data/dolfyn/AQD_HR.prf' ```
3 participants
This is a continuation and refinement of #435
Highlights:
From #435
Dependencies
Module Dependencies
allConda and Conda-Forge Dependency Definitions
Actions
Linting
blackon files that have changedCoveralls
Error: Bad response: 530 error code: 1016per: https://status.coveralls.io/ and this implements the recommendedfail-on-error: falsefixWe can incorporate this into #435 if that makes sense. My main goal here is to understand what changes are necessary in #435